-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add example for kubeflow spot instance cluster config #2640
Add example for kubeflow spot instance cluster config #2640
Conversation
Helps users build a highly cost efficient Kubeflow cluster for ML/DL training at 50-80% less cost
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @arjun921 , very nice and complete example! Thank you!
I only have one nitpick and it's that it would be nice to split long lines (line number 17, 93 etc) into shorter ones.
Other than that I think this can be rebased, approved and merged :)
Hi @martina-if , That's a really good catch! I'll make those changes and push soon. I have one doubt though, would it be helpful if I included a detailed blog post as a comment in the file? Here's the blog: I was thinking if it helps, I could include it like line 3 on the source: |
Yeah, I think the link could be useful for users 👍 |
@martina-if All requested changes done! |
numOfExamples 22 --> 23 to accomodate new examples
c2428ff
to
e304f66
Compare
NodeGroup.nodeGroups.desiredCapacity of type int
@martina-if I've updated test cases, |
Helps users build a highly cost efficient Kubeflow cluster for ML/DL training at 50-80% less cost
Description
Added cost efficient Kubeflow cluster spec with
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
), target version (e.g.version/0.12.0
) and kind (e.g.kind/improvement
)