Add Cluster-Autoscaling IAM #268
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmd/eksctl/create.go
Outdated
| @@ -99,6 +99,7 @@ func createClusterCmd() *cobra.Command { | |||
|
|
|||
| fs.BoolVar(&cfg.Addons.WithIAM.PolicyAmazonEC2ContainerRegistryPowerUser, "full-ecr-access", false, "enable full access to ECR") | |||
| fs.BoolVar(&cfg.Addons.Storage, "storage-class", true, "if true (default) then a default StorageClass of type gp2 provisioned by EBS will be created") | |||
| fs.BoolVar(&cfg.Addons.WithIAM.AutoScalingGroup, "auto-scaling-policy", false, "enable iam policy dependency for cluster-autoscaler") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/cfn/builder/iam.go
Outdated
| @@ -132,5 +132,18 @@ func (n *NodeGroupResourceSet) addResourcesForIAM() { | |||
| }, | |||
| ) | |||
|
|
|||
| if n.spec.Addons.WithIAM.AutoScalingGroup { | |||
| n.rs.attachAllowPolicy("AutoScalingControl", refIR, "*", | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
pkg/eks/api/api.go
Outdated
| @@ -89,4 +89,5 @@ type ClusterAddons struct { | |||
| // AddonIAM provides an addon for the AWS IAM integration | |||
| type AddonIAM struct { | |||
| PolicyAmazonEC2ContainerRegistryPowerUser bool | |||
| AutoScalingGroup bool | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Naming consistency makes a lot of sense here, that was the biggest thing I was struggling with. |
|
@Lazyshot would you mind to rebase and squash please? |
Lazyshot
force-pushed
the
feature/cluster-autoscaler-iam
branch
from
d75e954 to
f216ac9
Compare
|
There seem to be conflicts... |
|
I am keen to get this in soon and cut 0.1.7! |
|
I'll rebase again from master. |
Adds the ability and flag for requesting the necessary policy for the cluster-autoscaler application. This will be revisited once the add-on work is done. Issue #170
Lazyshot
force-pushed
the
feature/cluster-autoscaler-iam
branch
from
f216ac9 to
7ae8543
Compare
errordeveloper
approved these changes
Oct 18, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds the ability and flag for requesting the necessary
policy for the cluster-autoscaler application. This will
be revisited once the add-on work is done.
Issue #170
Checklist
make build)make test)