Initial command restructure #272
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prior to adding 'create/get/delete nodegroup' some refactoring has been done on the commands. We had a single file for all the commands for that verb so this has been changed to separate folders/files. Signed-off-by: Richard Case <richard.case@outlook.com>
The 'pkg/commands' package has been renamed to 'pkg/ctl' based on feedback. Signed-off-by: Richard Case <richard.case@outlook.com>
Lazyshot
approved these changes
Oct 17, 2018
| ) | ||
|
|
||
| var ( | ||
| utilsKubeconfigInputPath string |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
Thanks @Lazyshot |
|
🎉 |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Prior to adding 'create/get/delete nodegroup' (#257) some refactoring
has been done on the commands. We had a single file for all
the commands for that verb so this has been changed to separate
folders/files.
The version command has been left where it for simplicity with the code gen as its already in main.
The new package name has been called `pkg/ctl' based on feedback.
Checklist
make build)make test)humans.txtfile