WIP: More VPC features #285
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This will accommodate for - multiple nodegroups - public and private subnets - use taskmanager tasks for nodegroup(s) deletion - cleanup nodegroup terminology
golangcibot
reviewed
Oct 25, 2018
| "fmt" | ||
|
|
||
| "github.com/kubicorn/kubicorn/pkg/logger" | ||
| "k8s.io/kops/pkg/util/subnet" |
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
errordeveloper
force-pushed
the
more-vpc-features
branch
4 times, most recently
from
8468139 to
1265dad
Compare
- automate splitting of subnets - create private subnets as well as public
errordeveloper
force-pushed
the
more-vpc-features
branch
2 times, most recently
from
aa18292 to
06ea473
Compare
- ensure control plane uses private subnets - add NAT Gateway
errordeveloper
force-pushed
the
more-vpc-features
branch
from
06ea473 to
7c62d47
Compare
|
Closing in favour of separate PRs. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two flags:
--vpc-cidrlets user specify a custom CIDR--node-private-networkinglets user make networking of initial nodegroup privateThis PR depends on #283
Checklist
make build)make test)