Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show status of fargate profile in get command. #2886

Merged

Conversation

hvydya
Copy link
Contributor

@hvydya hvydya commented Dec 1, 2020

Show status of fargate profile when get fargateprofile is called.

Closes #2845

Copy link
Contributor

@aclevername aclevername left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, some conflicts with master need to be resolved 😄

@hvydya
Copy link
Contributor Author

hvydya commented Dec 2, 2020

So the conflicting file is auto-generated. Should I accept all changes from my branch to resolve them? Or do i need to re-generate those because accepting all my changes might affect the changes which were not made by me...Seems like latter one is the way to go. Let me know how to resolve this. 😄

@aclevername
Copy link
Contributor

So the conflicting file is auto-generated. Should I accept all changes from my branch to resolve them? Or do i need to re-generate those because accepting all my changes might affect the changes which were not made by me...Seems like latter one is the way to go. Let me know how to resolve this. 😄

Hey @hvydya, as you pointed out its an auto-generated file, so normally I would accept HEAD as part of the conflict, and then re-generate the files as this will always result in the desired outcome. Running make test will include the steps to re-generate the code 😄

@hvydya hvydya force-pushed the show-status-fargate-profile branch from ac43445 to 268feda Compare December 3, 2020 04:10
@michaelbeaumont
Copy link
Contributor

Thanks @hvydya !

@michaelbeaumont michaelbeaumont merged commit 531b1cd into eksctl-io:master Dec 8, 2020
@aclevername aclevername mentioned this pull request Jan 5, 2021
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Getting Fargate profiles should show profile statuses
4 participants