Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Follow-up on #305 #310

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Follow-up on #305 #310

merged 2 commits into from
Nov 9, 2018

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Nov 8, 2018 •
edited
Loading

Description

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)

@errordeveloper errordeveloper mentioned this pull request Nov 8, 2018
Closed
@errordeveloper errordeveloper force-pushed the subnets branch 2 times, most recently from 896e3c0 to 6687ae3 Compare November 8, 2018 15:04
@errordeveloper errordeveloper requested review from gruebel and richardcase and removed request for gruebel November 8, 2018 15:04
@errordeveloper errordeveloper force-pushed the subnets branch 2 times, most recently from 1d1097a to f6d7b46 Compare November 8, 2018 15:47
golangcibot
golangcibot reviewed Nov 8, 2018
View reviewed changes
pkg/vpc/vpc.go Outdated Show resolved Hide resolved
@errordeveloper
Create vpc.ImportSubnets
d6b1943 
- refactor all VPC helpers into new package
- make sure to only use the provider interface
@errordeveloper
Fix subnet ordering assumption
5a8e339 
- pass full provider to stack manager and cluster stack builder
stefanprodan
stefanprodan approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@stefanprodan stefanprodan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Nice refactoring @errordeveloper having a vpc package makes the code easier to understand

richardcase
richardcase approved these changes Nov 9, 2018
View reviewed changes
Copy link
Contributor

@richardcase richardcase left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@errordeveloper errordeveloper merged commit 39b2ca6 into master Nov 9, 2018
@errordeveloper
Copy link
Contributor Author

@richardcase @stefanprodan thanks for the review, I'm looking forward to this weeks release with all VPC customisations some users been waiting for!

@errordeveloper errordeveloper deleted the subnets branch November 9, 2018 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@golangcibot golangcibot golangcibot left review comments

@stefanprodan stefanprodan stefanprodan approved these changes

@richardcase richardcase richardcase approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Follow up on #305 nodegroup stack builder should not assume subnet/AZ mapping based on the order
4 participants
@errordeveloper @richardcase @stefanprodan @golangcibot