Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve stack template descriptions #312

Merged
merged 2 commits into from
Nov 9, 2018
Merged

Improve stack template descriptions #312

merged 2 commits into from
Nov 9, 2018

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Nov 9, 2018 •
edited
Loading

Description

  • fixes hardcoded values for nodegroup features
  • adds tests
  • fixes panic that comes up in unit tests due to unset VPC CIDR

Checklist

  • Code compiles correctly (i.e make build)
  • All tests passing (i.e. make test)

@errordeveloper errordeveloper merged commit 1e3f9c4 into master Nov 9, 2018
@errordeveloper errordeveloper deleted the stack-template-desc branch November 9, 2018 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@errordeveloper