Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix regression in getClusterName helper #517

Merged
merged 2 commits into from
Feb 7, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

A regression was introduced in #511, it resulted in DescribeClusterStack returning nodegroup stack, and that got passed on to the nodegroup validator resulting in shared SG check failing.

It surfaced in the integration test, and this is what it looked like:

 $ ./eksctl create nodegroup --cluster=ridiculous-hideout-1549472274 --region=us-west-2 --nodes=4 --node-private-networking ng-1 --verbose=4
2019-02-06T17:18:55Z [ℹ]  using region us-west-2
2019-02-06T17:18:56Z [▶]  role ARN for the current session is "arn:aws:iam::376248598259:user/ilya"
2019-02-06T17:18:57Z [▶]  resolving AMI using StaticGPUResolver for region us-west-2, instanceType m5.large and imageFamily AmazonLinux2
2019-02-06T17:18:57Z [▶]  can't resolve AMI using StaticGPUResolver as instance type m5.large is non-GPU
2019-02-06T17:18:57Z [▶]  resolving AMI using StaticDefaultResolver for region us-west-2, version m5.large, instanceType AmazonLinux2 and imageFamily %!!(MISSING)s(MISSING)
2019-02-06T17:18:58Z [ℹ]  nodegroup "ng-1" will use "ami-0a2abab4107669c1b" [AmazonLinux2/1.11]
2019-02-06T17:19:00Z [▶]  err = no ouput "SharedNodeSecurityGroup" in stack "eksctl-ridiculous-hideout-1549472274-nodegroup-ng-1"
2019-02-06T17:19:00Z [✖]  cluster compatibility check failed: shared node security group missing, to fix this run 'eksctl utils update-cluster-stack --name=ridiculous-hideout-1549472274 --region=us-west-2'
 $

Basically it wasn't supposed to look at eksctl-ridiculous-hideout-1549472274-nodegroup-ng-1, it was meant to look at eksctl-ridiculous-hideout-1549472274-cluster instead.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)

@errordeveloper errordeveloper mentioned this pull request Feb 7, 2019
3 tasks
@errordeveloper errordeveloper force-pushed the fix-cluster-name-getters branch from f018519 to e3c613c Compare February 7, 2019 09:46
@errordeveloper errordeveloper merged commit cd49dfb into master Feb 7, 2019
@errordeveloper errordeveloper deleted the fix-cluster-name-getters branch February 7, 2019 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant