Fix regression in getClusterName
helper
#517
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
A regression was introduced in #511, it resulted in
DescribeClusterStack
returning nodegroup stack, and that got passed on to the nodegroup validator resulting in shared SG check failing.It surfaced in the integration test, and this is what it looked like:
Basically it wasn't supposed to look at
eksctl-ridiculous-hideout-1549472274-nodegroup-ng-1
, it was meant to look ateksctl-ridiculous-hideout-1549472274-cluster
instead.Checklist
make build
)make test
)