Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve testing, fix flaky deletion error #521

Merged
merged 9 commits into from
Feb 7, 2019
Merged

Improve testing, fix flaky deletion error #521

merged 9 commits into from
Feb 7, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

  • improve linter settings, enable misspell
  • satisfy new linters
  • fix flaky deletion error (i.e. do not error when stack was actually deleted already)
  • use docker to make it easier to run multiple integration tests at the same time with different code

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All tests passing (i.e. make test)

@errordeveloper errordeveloper merged commit 55706e7 into master Feb 7, 2019
@errordeveloper errordeveloper deleted the improve-testing branch February 7, 2019 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@errordeveloper