Allow user to override node bootstrap script #522
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
fix-69
branch
2 times, most recently
from
4fbfa95
to
e13ef8c
Compare
errordeveloper
changed the title
errordeveloper
force-pushed
the
fix-69
branch
from
e13ef8c
to
c389ffb
Compare
jrryjcksn
reviewed
Feb 7, 2019
jrryjcksn
reviewed
Feb 7, 2019
errordeveloper
force-pushed
the
fix-69
branch
2 times, most recently
from
2e2d085
to
a18d4d4
Compare
This should allow those who _know what their are doing_ to pass
a custom script to run inside of cloud-init. Anyone looking to
use this will need to defined a shell script that would resemble
`bootstrap.{al2,ubuntu}.sh`. This should cater for any of advanced
use-cases, where additional files must be created on EC2 instances
prior to boot or anything of that nature. Alternative approach is
to use a custom AMI, or propose an eksctl feature, but this is
meant as a stop-gap for testing things out.
errordeveloper
force-pushed
the
fix-69
branch
from
a18d4d4
to
d6d762a
Compare
|
@jrryjcksn would you mind to re-approve this please? |
|
Not sure I have understood how should I provide to the eksctl command the user data I want to be used in the worker node |
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
…verwrite Allow volume attach limit overwrite via command line parameter
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This should close #69. It introduces a way for user to override the entier
bootstrap.{al2,ubuntu}.shwith their own version.Checklist
make build)make test)make integration-test)