Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix and improve integration tests #525

Merged
merged 1 commit into from
Feb 8, 2019
Merged

Fix and improve integration tests #525

merged 1 commit into from
Feb 8, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

Checklist

  • Code compiles correctly (i.e make build)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)

@errordeveloper
Fix and improve integration tests
35be42e 
- fix make targets, as cwd has changed
- remove extronous `newKubeTest`
- ensure test namespace is created at the right time
- provide a way to run a subset of tests
jrryjcksn
jrryjcksn approved these changes Feb 8, 2019
View reviewed changes
Copy link
Contributor

@jrryjcksn jrryjcksn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much cleaner. Why were we creating the namespace before?

@errordeveloper
Copy link
Contributor Author

Why were we creating the namespace before?

I think it was incidental. The test.Setup() call actually create the namespace, I think someone (probably me) misunderstanding of how the library works and got away with it.

@errordeveloper errordeveloper merged commit 3309f6f into master Feb 8, 2019
@errordeveloper errordeveloper deleted the fix-integration-tests branch February 8, 2019 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jrryjcksn jrryjcksn jrryjcksn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky tests - namespace doesn't exists
2 participants
@errordeveloper @jrryjcksn