Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Check-in build dependencies for faster builds #546

Merged
merged 2 commits into from
Feb 15, 2019
Merged

Check-in build dependencies for faster builds #546

merged 2 commits into from
Feb 15, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

This has two benefits:

  • it can be cached by docker
  • it avoid having to download these dependencies in CI

Checklist

  • Code compiles correctly (i.e make build)
  • All unit tests passing (i.e. make test)

@errordeveloper errordeveloper merged commit e8db88c into master Feb 15, 2019
@errordeveloper errordeveloper deleted the speedup-tests branch February 15, 2019 16:08
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
@k8s-ci-robot
Merge pull request eksctl-io#546 from ialidzhikov/nit/flag-description
fc47b6e 
Nit: improve flag description
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@errordeveloper