Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow creating Windows and Ubuntu nodegroups with NVIDIA GPU instances #5627

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Aug 16, 2022

Signed-off-by: Tibi 110664232+TiberiuGC@users.noreply.github.com

Description

We should be able to create Windows and Ubuntu nodegroups with NVIDIA GPU instances, which is why we
are removing the previously configured error for this scenario. However, we will log a warning as these AMIs don't ship with GPU drivers installed and we don't want give the illusion that running GPU-accelerated workloads will work out of the box.

Fixes #5256

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Signed-off-by: Tibi <110664232+TiberiuGC@users.noreply.github.com>
@TiberiuGC TiberiuGC changed the title Allow creating Windows and Ubuntu nodegroups with NVIDIA GPU instances Allow creating Windows and Ubuntu nodegroups with NVIDIA GPU instances #5256 Aug 16, 2022
@TiberiuGC TiberiuGC changed the title Allow creating Windows and Ubuntu nodegroups with NVIDIA GPU instances #5256 Allow creating Windows and Ubuntu nodegroups with NVIDIA GPU instances Aug 16, 2022
@TiberiuGC TiberiuGC added the skip-release-notes Causes PR not to show in release notes label Aug 16, 2022
@TiberiuGC TiberiuGC requested a review from a team August 16, 2022 12:27
Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello TiberiuGC 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-5 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@TiberiuGC TiberiuGC added kind/improvement area/nodegroup and removed skip-release-notes Causes PR not to show in release notes labels Aug 16, 2022
Copy link
Collaborator

@Himangini Himangini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@Himangini Himangini requested a review from cPu1 August 17, 2022 12:17
@TiberiuGC TiberiuGC merged commit d8f32f5 into eksctl-io:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] I should be able to create Windows and Ubuntu nodegroups with GPU instances (revert #4243)
4 participants