Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow node-role.kubernetes.io domain prefix in node labeling #582

Merged
merged 1 commit into from
Feb 26, 2019

Conversation

paulbsch
Copy link
Contributor

@paulbsch paulbsch commented Feb 26, 2019

Solution for issue #580

Description

Very simple change to allow node-role.kubernetes.io domain prefix in node labeling.

Checklist

  • Code compiles correctly (i.e make build)

Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @paulbsch! LGMT :)

@errordeveloper errordeveloper merged commit b54bc67 into eksctl-io:master Feb 26, 2019
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
Document behavior wrt minimum and maximum iops
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants