AWS Profile Changes #59
Conversation
Changes to ensure that AWS profiles are supported. This involved making sure that the AWS config file is loaded (SharedConfigEnabled) and also making sure we have a TokenProvider set. Added an explicit --profile flag that can be used to explicity specify which AWS profile you would like to use. This will override any profile that you have specified via AWS_PROFILE. If endpoints are being overriden then the credentials from the initial session creation are shared with any subsequent session creation to ensure that the tokens are shared (otherwise you may get multiple MFA prompts). Issue eksctl-io#57
There was a problem hiding this comment.
LGTM @richardcase 👍
Many thanks for the awesome work on this issue! ✨
cmd/eksctl/create.go
Outdated
| @@ -64,6 +64,7 @@ func createClusterCmd() *cobra.Command { | |||
|
|
|||
| fs.StringVarP(&cfg.ClusterName, "cluster-name", "n", "", fmt.Sprintf("EKS cluster name (generated if unspecified, e.g. %q)", exampleClusterName)) | |||
| fs.StringVarP(&cfg.Region, "region", "r", DEFAULT_EKS_REGION, "AWS region") | |||
| fs.StringVarP(&cfg.Profile, "profile", "p", "", "AWS Profile to use. This overrides the AWS_PROFILE environment variable if its set") | |||
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
This comment was marked as abuse.
This comment was marked as abuse.
Sorry, something went wrong.
|
N.B.:
EDIT: I tried a couple more things, see here, here and here. |
Changed the description for the --profile flag based on review feedback to improve the grammar and readability. Issue eksctl-io#57
|
@marccarre - small change with the text you suggested for the description of the --profile flag. |
|
@richardcase thanks a lot! |
There was a problem hiding this comment.
LGTM 👍 -- Did quite a bit of testing, both related and unrelated to the original issue, and this definitely improves things! Thank you so much @richardcase! ✨
|
@marccarre @errordeveloper - i think i've run into an issue with this with 'create cluster' and specifically `CreateDefaultNodeGroupAuthConfigMap'. This has come to light as part of my testing for #29. I will let you know what i find. |
Changes to ensure that AWS profiles are supported. This involved making
sure that the AWS config file is loaded (SharedConfigEnabled) and
also making sure we have a TokenProvider set.
Added an explicit --profile flag that can be used to explicity specify
which AWS profile you would like to use. This will override any profile
that you have specified via AWS_PROFILE.
If endpoints are being overriden then the credentials from the initial
session creation are shared with any subsequent session creation to
ensure that the tokens are shared (otherwise you may get multiple MFA
prompts).
Issue #57