Accept clientset interface over concrete type #607
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The concrete type `*kubernetes.Clientset` implements `kubernetes.Interface` and can as such be replaced in function arguments. It allows to pass in the k8s fake client when doing tests.
errordeveloper
approved these changes
Mar 5, 2019
2 tasks
torredil
pushed a commit
to torredil/eksctl
that referenced
this pull request
May 20, 2022
Update README.md
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The concrete type
*kubernetes.Clientsetimplementskubernetes.Interfaceand can as such be replaced in functionarguments. It allows to pass in the k8s fake client when doing tests.