Improve printers, use Go 1.12 #611
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
improve-printers
branch
from
b98b526 to
cf4e9ef
Compare
|
Will run integration tests, just in case :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Turns out Go 1.12 has
strings.ReplaceAll, which is quite handy. The wayLogObjworked wasn't particularly great, this allows user to specify full format string (they must include one%sfor the actual object. We now also ensure that the actual objects in question don't get use as formatting strings (e.g. some Kubernetes field values use%character), and we also try to serialise directly whenever API-aware serialiser fails to (e.g. unregistered APIs, missingapiVersionetc).Closes #603.
Checklist
make build)make test)make integration-test)