Improve Kubernetes client to support add-ons #617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- convert to runtime.Object - use list flattener from kubegen
errordeveloper
force-pushed
the
addons-client-support
branch
2 times, most recently
from
ba5f04e to
fe273e0
Compare
- improve naming of types and functions - enable use of raw REST client
errordeveloper
force-pushed
the
addons-client-support
branch
from
fe273e0 to
e06cecb
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This change allows us to use raw REST client in a way how
kubectldoes it (we should eventually contribute some of this code tok8s.io/cli-runtime).It also extends the asset manifest loader to do the right thing we need to do when it comes to multidoc YAML files and lists.
Checklist
make build)make test)make integration-test)