Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve nodegroup waiter #631

Merged
merged 1 commit into from
Mar 13, 2019
Merged

Improve nodegroup waiter #631

merged 1 commit into from
Mar 13, 2019

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Mar 13, 2019 •
edited
Loading

Description

Misc improvements to nodegroup waiter:

  • return initial count of ready nodes
  • use intened comparison operator
  • close watcher as needed
  • use sets instead of counter

Checklist

  • Code compiles correctly (i.e make build)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)

@errordeveloper
Improve nodegroup waiter
fa87b14 
- return initial count of ready nodes
- use intened comparison operator
- close watcher as needed
- use sets instead of counter
@errordeveloper errordeveloper merged commit 2cf09c9 into master Mar 13, 2019
@errordeveloper errordeveloper deleted the improve-ng-waiter branch March 13, 2019 23:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@errordeveloper