Enable allow-ssh flag when a key is specified #657
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martina-if
force-pushed
the
autoenable-allow-ssh-flag
branch
from
39a0f1a to
c39c902
Compare
martina-if
force-pushed
the
autoenable-allow-ssh-flag
branch
from
c39c902 to
050d3bb
Compare
| if utils.NodeGroupName(ng.Name, nameArg) == "" { | ||
| return cmdutils.ErrNameFlagAndArg(ng.Name, nameArg) | ||
| } | ||
| ng.Name = utils.NodeGroupName(ng.Name, nameArg) |
There was a problem hiding this comment.
I missed this... the behaviour here is different from the other version, we will need to reinstate it somehow.
There was a problem hiding this comment.
Maybe I messed up in the rebase, but initially, I did the renaming of the ng.Name with the nameArg when it was provided. I can fix that
There was a problem hiding this comment.
No to worry, I have a fix for this in #671.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Checklist
make build)make test)