Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add option to add IAM policies for AWS ALB Ingress Controller #675

Merged
merged 1 commit into from
Mar 28, 2019
Merged

Add option to add IAM policies for AWS ALB Ingress Controller #675

merged 1 commit into from
Mar 28, 2019

Conversation

mcfedr
Copy link
Contributor

@mcfedr mcfedr commented Mar 28, 2019

Description

The AWS ALB Ingress Controller is a very useful part of any EKS stack, and so it would be very nice to be able to add its required policies automatically along with the others eksctl can add

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • All integration tests passing (i.e. make integration-test)
  • Added/modified documentation as required (such as the README.md, and examples directory)
  • Added yourself to the humans.txt file

@christopherhein christopherhein self-requested a review March 28, 2019 20:53
christopherhein
christopherhein approved these changes Mar 28, 2019
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 pending tests passing.

@errordeveloper

@errordeveloper
Copy link
Contributor

Thanks, this was a long awaited one!

@christopherhein
Copy link
Contributor

@M00nF1sh can you take a look at this as well?

@mcfedr mcfedr mentioned this pull request Mar 28, 2019
Closed
@M00nF1sh
Copy link
Contributor

/lgtm

@errordeveloper
Copy link
Contributor

xref #53

@errordeveloper errordeveloper merged commit fdca204 into eksctl-io:master Mar 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@christopherhein christopherhein christopherhein approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcfedr @errordeveloper @christopherhein @M00nF1sh