overcome rate limiting of ListStacks calls #689
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
errordeveloper
force-pushed
the
fix-567
branch
2 times, most recently
from
e7b4c09 to
5361eaa
Compare
errordeveloper
changed the title
|
LGTM! Nice work @errordeveloper |
christopherhein
previously approved these changes
Apr 1, 2019
cdenneen
previously approved these changes
Apr 1, 2019
This often causes a lot of paging, and we only need to list deleted stacks explicitly in one special case that requires double check if stack had already been deleted when an error has occurred.
errordeveloper
dismissed stale reviews from cdenneen and christopherhein
via
180a5ec
martina-if
reviewed
Apr 2, 2019
| client.DefaultRetryer | ||
| } | ||
|
|
||
| var _ request.Retryer = &LoggingRetryer{} |
There was a problem hiding this comment.
what is this variable here? Is it used? Is it supposed to be here?
There was a problem hiding this comment.
It is a common way of validating that given struct implements the interface.
There was a problem hiding this comment.
It is a common way of validating that given struct implements the interface.
This was referenced Apr 5, 2019
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This introduces custom retry handler (copied from kops).
I am not sure why
DefaultRetryerdidn't work, but this adds debug logs, so we will get a better idea of when the retry delay kicks in.Most importantly it adds a built-in filter for non-deleted stacks that is set by default, and removed an extraneous call to
ListStacks.This fixes #567.
Checklist
make build)make test)