Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable strict parsing #702

Merged
merged 1 commit into from
Apr 5, 2019
Merged

Enable strict parsing #702

merged 1 commit into from
Apr 5, 2019

Conversation

errordeveloper
Copy link
Contributor

Description

This allows us to error when config has unknown fields.

Checklist

  • Code compiles correctly (i.e make build)
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)

martina-if
martina-if previously approved these changes Apr 5, 2019
pkg/eks/api_test.go Outdated Show resolved Hide resolved
pkg/eks/api.go Show resolved Hide resolved
@errordeveloper errordeveloper force-pushed the strict-config-parsing branch from 83a890d to 5ec469c Compare April 5, 2019 10:53
@errordeveloper errordeveloper merged commit ae4cdff into master Apr 5, 2019
@errordeveloper errordeveloper deleted the strict-config-parsing branch June 17, 2019 07:34
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
Refactor inFlight key to add lock per volumeId
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants