Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move addons related tasks to actions package #7077

Merged
merged 6 commits into from
Sep 27, 2023
Merged

Move addons related tasks to actions package #7077

merged 6 commits into from
Sep 27, 2023

Conversation

TiberiuGC
Copy link
Collaborator

Description

Closes #6964

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the area/tech-debt Leftover improvements in code, testing and building label Sep 18, 2023
@TiberiuGC TiberiuGC marked this pull request as ready for review September 18, 2023 09:00
a-hilaly
a-hilaly approved these changes Sep 26, 2023
View reviewed changes
pkg/actions/addon/tasks.go Outdated Show resolved Hide resolved
pkg/actions/addon/tasks.go Outdated Show resolved Hide resolved
@TiberiuGC TiberiuGC enabled auto-merge (squash) September 27, 2023 06:43
@TiberiuGC TiberiuGC merged commit 29164ee into eksctl-io:main Sep 27, 2023
9 checks passed
@TiberiuGC TiberiuGC mentioned this pull request Sep 27, 2023
Merged
7 tasks
IdanShohamNetApp pushed a commit to spotinst/weaveworks-eksctl that referenced this pull request Oct 19, 2023
@TiberiuGC @a-hilaly @IdanShohamNetApp
Move addons related tasks to actions package (eksctl-io#7077)
0ff506e 
* Move addons related tasks to actions package

* improve error message displaying format

Co-authored-by: Amine <hilalyamine@gmail.com>

* improve error message displaying format (2.0)

Co-authored-by: Amine <hilalyamine@gmail.com>

---------

Co-authored-by: Amine <hilalyamine@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

@a-hilaly a-hilaly a-hilaly approved these changes

Assignees
No one assigned
Labels
area/tech-debt Leftover improvements in code, testing and building
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Task] Move addons related tasks to actions package
3 participants
@TiberiuGC @cPu1 @a-hilaly