Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support other ssh options #713

Merged
merged 11 commits into from
Apr 26, 2019
Merged

Support other ssh options #713

merged 11 commits into from
Apr 26, 2019

Conversation

martina-if
Copy link
Contributor

@martina-if martina-if commented Apr 8, 2019 •
edited
Loading

closes #386
Support different ways to use SSH keys: by local file, by the key content and through the name of a key already imported in EC2

Checklist

  • rebase
  • Added tests that cover your change (if possible)
  • All unit tests passing (i.e. make test)
  • Manually tested
  • Added/modified documentation as required (such as the README.md, and examples directory)

@martina-if martina-if force-pushed the support-other-ssh-options branch 2 times, most recently from c50cb95 to 44d82dd Compare April 8, 2019 13:36
@martina-if martina-if force-pushed the support-other-ssh-options branch 2 times, most recently from fc2ff2c to e0c9c3a Compare April 9, 2019 12:11
@martina-if martina-if changed the title WIP: Support other ssh options Support other ssh options Apr 9, 2019
@errordeveloper errordeveloper mentioned this pull request Apr 9, 2019
Closed
@martina-if martina-if force-pushed the support-other-ssh-options branch from 19a3c55 to 5b143a3 Compare April 10, 2019 08:05
@errordeveloper errordeveloper mentioned this pull request Apr 12, 2019
Closed
errordeveloper
errordeveloper reviewed Apr 12, 2019
View reviewed changes
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
errordeveloper
errordeveloper reviewed Apr 12, 2019
View reviewed changes
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
errordeveloper
errordeveloper reviewed Apr 12, 2019
View reviewed changes
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
errordeveloper
errordeveloper reviewed Apr 12, 2019
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! I just added a few comments, mostly cosmetic :)

Looks like plenty of unit tests also 🥇

@martina-if martina-if force-pushed the support-other-ssh-options branch 2 times, most recently from d152561 to 3a692be Compare April 23, 2019 11:41
@adriamorgado adriamorgado mentioned this pull request Apr 25, 2019
Closed
@martina-if martina-if force-pushed the support-other-ssh-options branch from 3a692be to fd6c771 Compare April 26, 2019 09:28
errordeveloper
errordeveloper reviewed Apr 26, 2019
View reviewed changes
pkg/ssh/ssh.go Outdated Show resolved Hide resolved
errordeveloper
errordeveloper reviewed Apr 26, 2019
View reviewed changes
pkg/utils/file.go Outdated Show resolved Hide resolved
@martina-if martina-if force-pushed the support-other-ssh-options branch from 48dd71e to 4da506e Compare April 26, 2019 13:01
errordeveloper
errordeveloper reviewed Apr 26, 2019
View reviewed changes
pkg/utils/file.go Outdated Show resolved Hide resolved
errordeveloper
errordeveloper reviewed Apr 26, 2019
View reviewed changes
pkg/utils/file.go Outdated Show resolved Hide resolved
@martina-if martina-if force-pushed the support-other-ssh-options branch from 9b2762f to 1d93016 Compare April 26, 2019 13:33
errordeveloper
errordeveloper previously approved these changes Apr 26, 2019
View reviewed changes
Copy link
Contributor

@errordeveloper errordeveloper left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀:tada:

@martina-if martina-if merged commit 30c3a2c into eksctl-io:master Apr 26, 2019
@errordeveloper errordeveloper mentioned this pull request Apr 29, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StevenACoffman StevenACoffman StevenACoffman left review comments

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

refactor ng.AllowSSH and related fields into a separate struct
3 participants
@martina-if @errordeveloper @StevenACoffman