Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use authenticator with existing STS client #72

Merged
merged 1 commit into from
Jun 21, 2018
Merged

Use authenticator with existing STS client #72

merged 1 commit into from
Jun 21, 2018

Conversation

errordeveloper
Copy link
Contributor

@errordeveloper errordeveloper commented Jun 20, 2018 •
edited
Loading

@errordeveloper
Copy link
Contributor Author

errordeveloper commented Jun 20, 2018 •
edited
Loading

@richardcase would you mind to look over this please?

@errordeveloper errordeveloper mentioned this pull request Jun 20, 2018
Closed
@errordeveloper
Copy link
Contributor Author

I did a simple test with --profile and without AWS_PROFILE and it seems to work, I'd like to rebase it on #66 and test both features together, but not sure if I'll find time tomorrow.

@errordeveloper errordeveloper requested a review from d-nishi June 20, 2018 05:28
@richardcase
Copy link
Contributor

@errordeveloper - looks good to me. A nicer fix than the workaround of setting AWS_PROFILE for the token generation.

christopherhein
christopherhein reviewed Jun 20, 2018
View reviewed changes
Copy link
Contributor

@christopherhein christopherhein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Would the plan be to move forward w/ the fork expecting that we get that merged? I'm good either way as long as we get this converged eventually.

@christopherhein
Copy link
Contributor

Looks like the other PR is merged so lets get this updated with the upstream authenticator then :shipit: !

@errordeveloper errordeveloper force-pushed the fix-authenticator-profile branch from 73732be to 9a8351c Compare June 21, 2018 15:13
@errordeveloper errordeveloper merged commit a8c9e46 into master Jun 21, 2018
@errordeveloper errordeveloper deleted the fix-authenticator-profile branch June 21, 2018 15:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@christopherhein christopherhein christopherhein left review comments

@d-nishi d-nishi Awaiting requested review from d-nishi

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@errordeveloper @richardcase @christopherhein