Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CRUD Suite] Delete extra subnet before deleting cluster #7248

Merged
merged 13 commits into from
Nov 3, 2023
Merged

[CRUD Suite] Delete extra subnet before deleting cluster #7248

Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
f42cd30
Improve CRUD suite runtime~
TiberiuGC Oct 23, 2023
81465f0
refactor to use ginkgo decorators
TiberiuGC Oct 25, 2023
26712ba
Merge branch 'main' into maintenance/improve-crud-suite-runtime
TiberiuGC Oct 25, 2023
d8a70a0
fix IAM service account
TiberiuGC Oct 25, 2023
394cbc1
change cluster name
TiberiuGC Oct 25, 2023
a595aac
remove duplicate cluster workloads test
TiberiuGC Oct 26, 2023
bd4e444
refactor describe stacks test
TiberiuGC Oct 27, 2023
aee645e
Merge remote-tracking branch 'upstream/main' into maintenance/improve…
TiberiuGC Nov 2, 2023
e54348b
[CRUD integration] Add wait flag to delete cluster command
TiberiuGC Nov 2, 2023
fe118e6
Merge branch 'main' into maintenance/improve-crud-suite-runtime
TiberiuGC Nov 3, 2023
7fad9e4
delete additional subnet
TiberiuGC Nov 3, 2023
6da4bae
fix typo
TiberiuGC Nov 3, 2023
4fd4e2f
small refactor to trigger workflows
TiberiuGC Nov 3, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions integration/tests/crud/creategetdelete_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1083,6 +1083,11 @@ var _ = Describe("(Integration) Create, Get, Scale & Delete", func() {
})

var _ = SynchronizedAfterSuite(func() {}, func() {
// before deleting the cluster, first delete the additional subnet
ec2 := awsec2.NewFromConfig(NewConfig(params.Region))
_, err := ec2.DeleteSubnet(context.Background(), &awsec2.DeleteSubnetInput{SubnetId: &extraSubnetID})
Expect(err).NotTo(HaveOccurred())

Expect(params.EksctlDeleteCmd.WithArgs(
"cluster", params.ClusterName,
"--wait",
Expand Down
Loading