Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename preBootstrapCommand to preBootstrapCommands #726

Merged
merged 1 commit into from
Apr 15, 2019
Merged

Rename preBootstrapCommand to preBootstrapCommands #726

merged 1 commit into from
Apr 15, 2019

Conversation

martina-if
Copy link
Contributor

@martina-if martina-if commented Apr 12, 2019 •
edited by errordeveloper
Loading

closes #591

  • Code compiles correctly (i.e make build)
  • All unit tests passing (i.e. make test)
  • Added/modified documentation as required (such as the README.md, and examples directory)

@errordeveloper errordeveloper merged commit 93cc5eb into eksctl-io:master Apr 15, 2019
@errordeveloper errordeveloper mentioned this pull request Apr 30, 2019
Closed
2 tasks
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
@wongma7
Merge pull request eksctl-io#726 from AndyXiangLi/external-e2e-test
0d9e88b 
Integrate external e2e test in the testsuits
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

preBootsrapCommand should be renamed to preBootsrapCommands
2 participants
@martina-if @errordeveloper