-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump dependencies #7554
Bump dependencies #7554
Conversation
52557ab
to
233ec1c
Compare
pkg/kubernetes/client.go
Outdated
expander := restmapper.NewShortcutExpander(mapper, discoveryClient, nil) | ||
return expander, nil | ||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not super sure if this is correct to do (passing a nil function)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like it's safe.. https://github.com/kubernetes/client-go/blob/master/restmapper/shortcut.go#L167-L169
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we can pass a function that will log the warning?
pkg/kubernetes/client.go
Outdated
@@ -540,7 +540,7 @@ func (c *SimpleRESTClientGetter) ToRESTMapper() (meta.RESTMapper, error) { | |||
} | |||
|
|||
mapper := restmapper.NewDeferredDiscoveryRESTMapper(discoveryClient) | |||
expander := restmapper.NewShortcutExpander(mapper, discoveryClient) | |||
expander := restmapper.NewShortcutExpander(mapper, discoveryClient, nil) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
expander := restmapper.NewShortcutExpander(mapper, discoveryClient, nil) | |
expander := restmapper.NewShortcutExpander(mapper, discoveryClient, func(a string) { | |
logger.Warning("unexpected warning message %s", a) | |
}) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
how about this? @a-hilaly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's great!
233ec1c
to
6e9d017
Compare
Signed-off-by: Amine Hilaly <hilalyamine@gmail.com>
Update go version to 1.21 in actions
6e9d017
to
0cb2f05
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @yuxiang-zhang !
Description
Closes #7472 #7492 #7494 #7506 #7508 #7510 #7514 #7527 #7528 #7529 #7531 #7532 #7533 #7534 #7535 #7536 #7537 #7544 #7545 #7546 #7547
Checklist
README.md
, or theuserdocs
directory)area/nodegroup
) and kind (e.g.kind/improvement
)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯