Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase STS session duration to fix caching credentials with assumed role MFA session #7626

Merged

Conversation

vutny
Copy link
Contributor

@vutny vutny commented Feb 29, 2024

Description

This PR fixes issue #7404

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello vutny 👋 Thank you for opening a Pull Request in eksctl project. The team will review the Pull Request and aim to respond within 1-10 business days. Meanwhile, please read about the Contribution and Code of Conduct guidelines here. You can find out more information about eksctl on our website

@yuxiang-zhang yuxiang-zhang changed the title Fix caching credentials with assummed role MFA session Increase STS session duration to fix caching credentials with assumed role MFA session Feb 29, 2024
@yuxiang-zhang yuxiang-zhang merged commit 7c62894 into eksctl-io:main Feb 29, 2024
12 of 13 checks passed
@vutny vutny deleted the fix-assume-role-session-duration branch March 1, 2024 08:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants