Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Github workflow for updating generated files for default addons #7766

Merged
merged 2 commits into from
Jun 7, 2024

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented May 16, 2024

Description

The Github workflow responsible for upgrading the manifests for default aws-node and coredns addons has been broken for a while.
https://github.com/eksctl-io/eksctl/actions/workflows/update-generated.yaml

This PR aims to provide a fix for that. People have been experiencing issues with eksctl utils update commands since the generated files were out of date for long period of time. e.g. #7755

Additionally, the PR includes a fix for the update coredns PR, as in, it excludes preview versions when trying to resolve the latest. Manual test for that #7767

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC changed the title Fix github workflow for updating generated files for default addons Fix Github workflow for updating generated files for default addons May 16, 2024
@TiberiuGC TiberiuGC force-pushed the bugfix/update-generated-files branch from c521b08 to 888e903 Compare May 16, 2024 19:21
@TiberiuGC TiberiuGC force-pushed the bugfix/update-generated-files branch from f54465a to c1c06cf Compare May 17, 2024 10:35
@TiberiuGC TiberiuGC marked this pull request as ready for review May 17, 2024 11:25
@TiberiuGC TiberiuGC mentioned this pull request Jun 5, 2024
@TiberiuGC TiberiuGC force-pushed the bugfix/update-generated-files branch from c1c06cf to a33bfab Compare June 7, 2024 09:43
@cPu1 cPu1 merged commit e7c402c into main Jun 7, 2024
9 checks passed
@cPu1 cPu1 deleted the bugfix/update-generated-files branch June 7, 2024 09:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants