Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AWS G6 GPU instance support #7819

Merged
merged 4 commits into from
Jun 6, 2024
Merged

Added AWS G6 GPU instance support #7819

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
105b6db
G6 support
practicusai Jun 6, 2024
09dd74f
Update pkg/addons/assets/efa-device-plugin.yaml
practicusai Jun 6, 2024
a1f05d3
Update pkg/addons/assets/efa-device-plugin.yaml
practicusai Jun 6, 2024
7aade08
Merge branch 'main' into g6-support
practicusai Jun 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 10 additions & 0 deletions pkg/addons/assets/efa-device-plugin.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,6 +56,11 @@ spec:
- g4dn.8xlarge
- g4dn.metal
- g5.48xlarge
- g6.8xlarge
- g6.12xlarge
- g6.16xlarge
- g6.24xlarge
- g6.48xlarge
practicusai marked this conversation as resolved.
Show resolved Hide resolved
- hpc6a.48xlarge
- i3en.12xlarge
- i3en.24xlarge
Expand Down Expand Up @@ -113,6 +118,11 @@ spec:
- g4dn.8xlarge
- g4dn.metal
- g5.48xlarge
- g6.8xlarge
- g6.12xlarge
- g6.16xlarge
- g6.24xlarge
- g6.48xlarge
practicusai marked this conversation as resolved.
Show resolved Hide resolved
- hpc6a.48xlarge
- i3en.12xlarge
- i3en.24xlarge
Expand Down
8 changes: 8 additions & 0 deletions pkg/apis/eksctl.io/v1alpha5/gpu_validation_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -61,6 +61,10 @@ var _ = Describe("GPU instance support", func() {
gpuInstanceType: "asdf",
amiFamily: api.NodeImageFamilyAmazonLinux2,
}),
Entry("AL2", gpuInstanceEntry{
gpuInstanceType: "g6.12xlarge",
amiFamily: api.NodeImageFamilyAmazonLinux2,
}),
Entry("AL2", gpuInstanceEntry{
gpuInstanceType: "g5.12xlarge",
amiFamily: api.NodeImageFamilyAmazonLinux2,
Expand Down Expand Up @@ -124,6 +128,10 @@ var _ = Describe("GPU instance support", func() {
gpuInstanceType: "g4dn.xlarge",
amiFamily: api.NodeImageFamilyAmazonLinux2,
}),
Entry("AL2", gpuInstanceEntry{
gpuInstanceType: "g6.12xlarge",
amiFamily: api.NodeImageFamilyAmazonLinux2,
}),
Entry("AL2", gpuInstanceEntry{
gpuInstanceType: "g5.12xlarge",
amiFamily: api.NodeImageFamilyAmazonLinux2,
Expand Down
3 changes: 2 additions & 1 deletion pkg/utils/instance/instance.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,7 +49,8 @@ func IsNvidiaInstanceType(instanceType string) bool {
strings.HasPrefix(instanceType, "p5") ||
strings.HasPrefix(instanceType, "g3") ||
strings.HasPrefix(instanceType, "g4") ||
strings.HasPrefix(instanceType, "g5")
strings.HasPrefix(instanceType, "g5") ||
strings.HasPrefix(instanceType, "g6")
}

// IsInferentiaInstanceType returns true if the instance type requires AWS Neuron
Expand Down