Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

use string in logging instead of wrapping error #7838

Merged
merged 1 commit into from
Jun 21, 2024
Merged

use string in logging instead of wrapping error #7838

merged 1 commit into from
Jun 21, 2024

Conversation

moreandres
Copy link
Contributor

Using %w outside of fmt.Errorf is not appropriate because %w is intended specifically for error wrapping.

cPu1
cPu1 approved these changes Jun 18, 2024
View reviewed changes
Copy link
Collaborator

@cPu1 cPu1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a known issue that affects some other logging calls as well.

@cPu1 cPu1 enabled auto-merge June 18, 2024 09:40
@cPu1 cPu1 merged commit 3cbd926 into eksctl-io:main Jun 21, 2024
9 of 10 checks passed
@eksctl-bot eksctl-bot mentioned this pull request Jun 14, 2024
Merged
@eksctl-bot eksctl-bot mentioned this pull request Jul 3, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cPu1 cPu1 cPu1 approved these changes

Assignees
No one assigned
Labels
kind/improvement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@moreandres @cPu1