Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GH workflow for automatically updating nvidia device plugin static manifest #7898

Merged
merged 4 commits into from
Jul 29, 2024

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Jul 26, 2024

Description

The static manifest file for nvidia device plugin hasn't been updated in a long time, pointing to v0.9.0. Introducing an automated workflow, similar to those for aws-node and coredns, to catch version updates and manually open a PR against eksctl.

Additionally, this improves the existing workflow to automatically print the release tag version in the commit message and PR description.

e.g. manual test #7900

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC marked this pull request as ready for review July 26, 2024 08:23
@TiberiuGC TiberiuGC requested a review from cPu1 July 26, 2024 08:23
@TiberiuGC TiberiuGC merged commit 7f91b9d into main Jul 29, 2024
10 checks passed
@TiberiuGC TiberiuGC deleted the add-update-nvidia-workflow branch July 29, 2024 12:06
TiberiuGC added a commit to TiberiuGC/eksctl that referenced this pull request Oct 7, 2024
…c manifest (eksctl-io#7898)

* Add GH workflow for automatically updating nvidia device plugin static manifest

* update PR body

* fix unit tests

* updates userdocs
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants