Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for preBootstrapCommands in AL2023 #8031

Merged
merged 1 commit into from
Dec 9, 2024

Conversation

TiberiuGC
Copy link
Collaborator

@TiberiuGC TiberiuGC commented Nov 4, 2024

Description

AL2023 bootstrapping is achieved via a new nodeadm process, as opposed to the old bootstrapping script used by AL2. The bootstrapping part of this nodeadm process is being run after the cloud-init process. Therefore, any shell script being included in the EC2 userdata is by default considered a pre-bootstrap command.

Closes #7903

Checklist

  • Added tests that cover your change (if possible)
  • Added/modified documentation as required (such as the README.md, or the userdocs directory)
  • Manually tested
  • Made sure the title of the PR is a good description that can go into the release notes
  • (Core team) Added labels for change area (e.g. area/nodegroup) and kind (e.g. kind/improvement)

BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯

  • Backfilled missing tests for code in same general area 🎉
  • Refactored something and made the world a better place 🌟

@TiberiuGC TiberiuGC added the kind/feature New feature or request label Nov 4, 2024
@TiberiuGC TiberiuGC force-pushed the feature/al2023-prebootstrap branch from bcff03e to 3371857 Compare November 5, 2024 06:13
@TiberiuGC TiberiuGC force-pushed the feature/al2023-prebootstrap branch from 3371857 to d85314c Compare December 4, 2024 05:55
Copy link
Member

@a-hilaly a-hilaly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@TiberiuGC TiberiuGC merged commit 3a50e37 into eksctl-io:main Dec 9, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/feature New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] preBootstrapCommands is not working in AL2023
2 participants