Allow importing subnets with IPv6 only #8086
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TiberiuGC
force-pushed
the
bugfix/ipv6-only-subnets-import
branch
from
940792f to
0d20d76
Compare
TiberiuGC
force-pushed
the
bugfix/ipv6-only-subnets-import
branch
from
0d20d76 to
00225cd
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, eksctl doesn't account for the scenario of creating a cluster using a pre-existing VPC in which some of the subnets are using IPv6 only. Thus, running into a panic. This PR fixes this issue and allows successful cluster creation in this case.
Passing e2e test runs against this branch
https://github.com/eksctl-io/eksctl-ci/actions/runs/12260313908
https://github.com/eksctl-io/eksctl-ci/actions/runs/12273069844/job/34317017082
Checklist
README.md, or theuserdocsdirectory)area/nodegroup) and kind (e.g.kind/improvement)BONUS POINTS checklist: complete for good vibes and maybe prizes?! 🤯