Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix search of ubuntu AMIs #823

Merged
merged 1 commit into from
May 29, 2019
Merged

Fix search of ubuntu AMIs #823

merged 1 commit into from
May 29, 2019

Conversation

martina-if
Copy link
Contributor

@martina-if martina-if commented May 27, 2019 •
edited
Loading

related to #818

Fix search pattern for ubuntu AMIs

  • Code compiles correctly (i.e make build)
  • All unit tests passing (i.e. make test)

@martina-if martina-if changed the title Fix search of ubuntu AMIs WIP Fix search of ubuntu AMIs May 27, 2019
@martina-if martina-if force-pushed the fix-ubuntu-ami-search branch from 7ba90ba to d593543 Compare May 27, 2019 08:38
@martina-if martina-if changed the title WIP Fix search of ubuntu AMIs Fix search of ubuntu AMIs May 27, 2019
@errordeveloper errordeveloper merged commit 3ffa0db into eksctl-io:master May 29, 2019
torredil pushed a commit to torredil/eksctl that referenced this pull request May 20, 2022
@k8s-ci-robot
Merge pull request eksctl-io#823 from wongma7/windowsforreal
dded803 
Implement Windows NodePublish/Unpublish
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@errordeveloper errordeveloper errordeveloper approved these changes

@christopherhein christopherhein Awaiting requested review from christopherhein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@martina-if @errordeveloper