Changes EFS IAM Policy Resource #829
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When IAM AddOn Policy for EFS is set to true the policy is generated specifying a wrong (fake) resource ARN `arn:aws:elasticfilesystem:us-west-2:123456789012:file-system/*`. The resource ARN in the policy statement should be in the format of `arn:aws:elasticfilesystem:<REGION>:<AWS_ACCOUNT>:file-system/*` or simply allow all resources `*` as is being done in the other addons like the EBS one. More information about EFS API Permissions can be found at: https://docs.aws.amazon.com/efs/latest/ug/efs-api-permissions-ref.html Issue eksctl-io#828
errordeveloper
approved these changes
May 30, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When IAM AddOn Policy for EFS is set to true the policy is generated
specifying a wrong (fake) resource ARN
arn:aws:elasticfilesystem:us-west-2:123456789012:file-system/*.The resource ARN in the policy statement should be in the format of
arn:aws:elasticfilesystem:<REGION>:<AWS_ACCOUNT>:file-system/*or simplyallow all resources
*as is being done in the other addons like the EBSone.
Fix #828
Checklist
make build)make test)make integration-test)