-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable policies for cert-manager. #885
Conversation
@Yannig thanks very much! This looks good overall, but I wonder if we should make this controlled by a dedicated config field instead of hanging it on |
@errordeveloper no problem. I'm doing it asap. |
@errordeveloper what do you think about it? |
@Yannig thank you, this looks good! Ideally, we would make this a config-only option, if you are okay with that? We have a strong preference to avoid adding new flags, as there are already too many. |
I understand. I'm doing the modification. |
e35dc29
to
a60ea29
Compare
@errordeveloper I think it's fine now. What do you think about? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good! If you have a moment to replace new PolicyExternalDNS
strings with PolicyCertManager
, it would be great, otherwise I'm happy to follow up.
This options adds needed policies to be able to deploy a certificate manager.
Done |
Fix for #745
Description
Checklist
make build
)make test
)make integration-test
)README.md
, andexamples
directory)humans.txt
file