Feature/multitarget

[MartyIX]

Fixes #80 (?)

Introduction

Attempts to bring back support for Android, iOS and MacCatalyst, removed in 954f936.

How to compile?

To compile code in this branch, one has to call:

dotnet workload install android
dotnet workload install ios
dotnet workload install maccatalyst

Now ideally restart Visual Studio, if that is your IDE.

Testing

I have run unit tests and they pass for me. I'm not sure how to test further. Any ideas?

Any feedback is much appreciated.

[MartyIX]

@ektrah Could you please allow CI runs for this PR for me to know if I got it right or wrong?

edit: Tested here: https://github.com/MartyIX/libsodium-core/actions/runs/3383999101/jobs/5620456128

[MartyIX]

@ektrah Does the PR make sense to you? Or do you think the approach is wrong?

[ektrah]

Thanks a lot for tackling this!

The PR looks quite good so far. A few comments:

• With the PR, the GitHub Action now builds a NuGet package that includes .dll's for net6.0, net6.0-android31.0, net6.0-ios16.0, and net6.0-maccatalyst15.4 in addition to netstandard2.1 and netstandard2.0. It would be great if the GitHub Action could be enhanced to show that it actually works (e.g., by not just building the .dll's for those platforms but also running the unit tests on them or by compiling a test project that references the built NuGet package or similar).
• There is some older documentation in Xamarin.md. Is that still relevant? Could it be updated to the .NET 6 way of doing things?

[MartyIX]

• It would be great if the GitHub Action could be enhanced to show that it actually works (e.g., by not just building the .dll's for those platforms but also running the unit tests on them or [..].

I've been slowly researching this but it does not seem to be as simple as adding dotnet test -f net6.0-maccatalyst -c Debug.

• There is some older documentation in Xamarin.md. Is that still relevant? Could it be updated to the .NET 6 way of doing things?

Not an expert on this. It would be great if the original author could give a hand :)

[ektrah]

/cc @enclave-alistair (who seems to be working on iOS support for another libsodium binding)

[MartyIX]

So I have been struggling with testing this:

• It seems that it's not easy to use xunit for testing net6.0-maccatalyst (see [dotnet] Unit test projects don't work xamarin/xamarin-macios#13319 for example)
• I tried to make it run in a sample (on mac M1): MartyIX@0cf32c3 but the libsodium library cannot be found. And I have not found a way to fix it so far.

[MartyIX]

So I have found out that .NET 7 console application on macOS works OK:

<Project Sdk="Microsoft.NET.Sdk">

  <PropertyGroup>
    <OutputType>Exe</OutputType>
    <TargetFramework>net7.0</TargetFramework>
    <RootNamespace>libsodium_core_console</RootNamespace>
    <ImplicitUsings>enable</ImplicitUsings>
    <Nullable>enable</Nullable>
  </PropertyGroup>

  <ItemGroup>
      <PackageReference Include="Sodium.Core" Version="1.3.1" />
  </ItemGroup>
</Project>

using Sodium;

internal class Program
{
    private static void Main(string[] args)
    {
        Console.WriteLine(SecretAeadAes.IsAvailable);
    }
}

The program above does not crash.

However, a similar .NET 7 MacCatalyst application crashes because it cannot find the libsodium DLL:

namespace libsodium_core_maccatalyst;

using Sodium;

[Register ("AppDelegate")]
public class AppDelegate : UIApplicationDelegate {
	public override UIWindow? Window {
		get;
		set;
	}

	public override bool FinishedLaunching (UIApplication application, NSDictionary launchOptions)
	{
		// create a new window instance based on the screen size
		Window = new UIWindow (UIScreen.MainScreen.Bounds);

		// create a UIViewController with a single UILabel
		var vc = new UIViewController ();
		vc.View!.AddSubview (new UILabel (Window!.Frame) {
			BackgroundColor = UIColor.SystemBackground,
			TextAlignment = UITextAlignment.Center,
			Text = SecretAeadAes.IsAvailable.ToString(), // MODIFIED LINE.
			AutoresizingMask = UIViewAutoresizing.All,
		});
		Window.RootViewController = vc;

		// make the window visible
		Window.MakeKeyAndVisible ();

		return true;
	}
}

So the problem is clear. The solution is not. :|

edit: I have asked a question here: dotnet/runtime#79502

[ektrah]

@MartyIX, thanks a lot for looking into this! Your findings show that there really should be some tests 🙂 I'm afraid I can't provide much help here, as I've never done any .NET ios/android/maccatalyst development.

[MartyIX]

Asked here jedisct1/libsodium#1235 as the issue is in libsodium and not in this library. At least as far as I understands it based on dotnet/runtime#79502 (reply in thread).

[MartyIX]

@ektrah So now we wait until libsodium releases (jedisct1/libsodium#1238 (comment)) so that this package can be modified to provide support for mac catalyst. But given jedisct1/libsodium#1136 there is no estimate I guess.