Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support asyncio redis #185

Merged
merged 6 commits into from
Aug 19, 2022
Merged

Support asyncio redis #185

merged 6 commits into from
Aug 19, 2022

Conversation

long2ice
Copy link
Contributor

No description provided.

@ekzhu
Copy link
Owner

ekzhu commented Jun 7, 2022

@long2ice thanks for the pull request! There seems to be a minor bug related to importlib changes in Python 3.8. See: https://stackoverflow.com/questions/59216175/importerror-cannot-import-name-metadata-from-importlib

@long2ice
Copy link
Contributor Author

long2ice commented Jun 7, 2022

Fixed

@ekzhu
Copy link
Owner

ekzhu commented Jun 23, 2022

It looks like the bug is still there:

==================================== ERRORS ====================================
_________________ ERROR collecting test/aio/test_lsh_mongo.py __________________
ImportError while importing test module '/home/runner/work/datasketch/datasketch/test/aio/test_lsh_mongo.py'.
Hint: make sure your test modules/packages have valid Python names.
Traceback:
/opt/hostedtoolcache/Python/3.6.[15](https://github.com/ekzhu/datasketch/runs/6998453721?check_suite_focus=true#step:9:16)/x64/lib/python3.6/importlib/__init__.py:126: in import_module
    return _bootstrap._gcd_import(name[level:], package, level)
test/aio/test_lsh_mongo.py:15: in <module>
    from datasketch.experimental.aio.lsh import AsyncMinHashLSH
datasketch/experimental/__init__.py:[18](https://github.com/ekzhu/datasketch/runs/6998453721?check_suite_focus=true#step:9:19): in <module>
    from datasketch.experimental.aio.lsh import AsyncMinHashLSH
datasketch/experimental/aio/lsh.py:11: in <module>
    from datasketch.experimental.aio.storage import (async_ordered_storage, async_unordered_storage, )
datasketch/experimental/aio/storage.py:2: in <module>
    from importlib import metadata
E   ImportError: cannot import name 'metadata'

@long2ice
Copy link
Contributor Author

Sorry, fixed again

@ekzhu
Copy link
Owner

ekzhu commented Jun 27, 2022

Thanks @long2ice . The issue is fixed. Would you mind add some documentation for this new feature? Currently the documentation only covers examples using MongoDB's Async IO API. It would be great to have a Redis version as well. This will increase the visibility of this new feature.

The current documentation on Async IO: http://ekzhu.com/datasketch/lsh.html#asynchronous-minhash-lsh-at-scale

The documentation source for this page: https://github.com/ekzhu/datasketch/blob/master/docs/lsh.rst

@long2ice
Copy link
Contributor Author

OK, I will do it

@long2ice
Copy link
Contributor Author

Done

@ekzhu ekzhu merged commit 6e7d228 into ekzhu:master Aug 19, 2022
@ekzhu
Copy link
Owner

ekzhu commented Aug 19, 2022

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants