Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Base #65

Merged
merged 7 commits into from
Aug 15, 2020
Merged

Base #65

merged 7 commits into from
Aug 15, 2020

Conversation

eladyaniv01
Copy link
Owner

No description provided.

eladyaniv01 and others added 7 commits August 13, 2020 21:15
BREAKING CHANGE: Region is now a Child of Polygon
* fix: __bool__ compatibility with burnysc2

burnysc2 overrides __bool__ for Point2  which causes calling list(map(numpy.array, Point2))  to map the x,y with numpy values ( and the bool check returns numpy_bool instead of __bool__)

* bump setup.py

* chore(release): 0.0.51
…alculate regions via perimeter points , and regions do not calculate ramps
…alculate regions via perimeter points , and regions do not calculate ramps

fix: regions and ramps now set each other correctly
@eladyaniv01 eladyaniv01 merged commit 209d6d1 into dev Aug 15, 2020
@eladyaniv01 eladyaniv01 deleted the Base branch August 15, 2020 16:18
eladyaniv01 added a commit that referenced this pull request Aug 15, 2020
* refactor: Region to inherit from Polygon + adjusted tests

BREAKING CHANGE: Region is now a Child of Polygon

* fix: __bool__ compatibility with burnysc2  (#64)

* fix: regions and ramps now set each other correctly
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant