Adding NodeJS tests for WASM module #262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pca006132
reviewed
Oct 27, 2022
bindings/wasm/test/test.js
Outdated
| const genus = manifold.genus(); | ||
| return { ...prop, genus }; | ||
| } catch (error) { | ||
| console.log(error.toString()); |
There was a problem hiding this comment.
Just wondering do we need to catch the error. I think it is also fine to just let the error propagate and catch by the unit test framework?
pca006132
approved these changes
Oct 27, 2022
|
FYI @stewartoallen, this adds a JS test framework you're welcome to add to. It's also a breaking change for our WASM, as it's now a module, so you have to update how it's imported. I think when we get your PR sorted out we'll probably do a v2.0 npm release. |
cartesian-theatrics
pushed a commit
to SovereignShop/manifold
that referenced
this pull request
Mar 11, 2024
* modularize wasm and add mocha tests * add npm tests to CI * fix mv command * revert to build directory * added rest of example tests * fixed three.js test * update web examples for module
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In order to get this working in Node I needed to modularize our WASM bundle, which I think is a good practice regardless. I tried going all the way to an ES6 module, but couldn't make it work. UPDATE: turns out I wasn't crazy, ES6 modules from Emscipten don't yet work in NodeJS. So we'll just stick with CommonJS for now until they fix that (I don't feel like dealing with workarounds, since this works just fine).