Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: exposes Quality::ResetToDefaults() via C bindings #964

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

NickUfer
Copy link
Contributor

Yesterday I started implementing rust bindings for this project and I wanted to run tests if my bindings for changing quality settings work as expected. I stumbled across the problem that tests fail when I run them all together instead of one by one.
I then pinned it down to the changed defaults, but I also figured out that there is no C binding for the reset function.

TL;DR: this PR exposes the Quality::ResetToDefaults() function via C bindings with roughly the same function name as for WASM (resetToCircularDefaults).

@NickUfer NickUfer force-pushed the expose-quality-reset-to-defaults-c branch from f546e40 to 82a62fa Compare September 29, 2024 16:32
Copy link

codecov bot commented Sep 29, 2024

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.28%. Comparing base (d437097) to head (82a62fa).
Report is 108 commits behind head on master.

Files with missing lines Patch % Lines
bindings/c/manifoldc.cpp 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #964      +/-   ##
==========================================
- Coverage   91.84%   88.28%   -3.56%     
==========================================
  Files          37       62      +25     
  Lines        4976     8653    +3677     
  Branches        0     1044    +1044     
==========================================
+ Hits         4570     7639    +3069     
- Misses        406     1014     +608     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Great to hear about Rust bindings - when you have something to share, please add it to our README; I want to make it easy for people to find all the Manifold bindings / packages that exist.

@elalish elalish merged commit ea91395 into elalish:master Sep 29, 2024
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants