Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

simple cleanup #973

Merged
merged 10 commits into from
Oct 2, 2024
Merged

simple cleanup #973

merged 10 commits into from
Oct 2, 2024

Conversation

pca006132
Copy link
Collaborator

No description provided.

Copy link

codecov bot commented Oct 1, 2024

Codecov Report

Attention: Patch coverage is 93.54839% with 2 lines in your changes missing coverage. Please review.

Project coverage is 88.21%. Comparing base (d437097) to head (6536356).
Report is 114 commits behind head on master.

Files with missing lines Patch % Lines
src/utils.h 81.81% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #973      +/-   ##
==========================================
- Coverage   91.84%   88.21%   -3.63%     
==========================================
  Files          37       62      +25     
  Lines        4976     8671    +3695     
  Branches        0     1044    +1044     
==========================================
+ Hits         4570     7649    +3079     
- Misses        406     1022     +616     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@pca006132 pca006132 requested a review from elalish October 1, 2024 14:34
Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, this looks great! How much of #969 does this address?

.github/workflows/manifold.yml Show resolved Hide resolved
src/boolean3.cpp Show resolved Hide resolved
src/boolean_result.cpp Outdated Show resolved Hide resolved
@pca006132
Copy link
Collaborator Author

Fixed 4 of them. Was focused on code cleanup, and removed a few files, so there are still trivial things that are not yet addressed here.

Copy link
Owner

@elalish elalish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Is this ready to merge?

@pca006132 pca006132 merged commit cc1e974 into elalish:master Oct 2, 2024
21 checks passed
@pca006132 pca006132 deleted the cleanup branch October 2, 2024 16:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants