Fix runWithRoles without api version in config #26
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
reiferschris
approved these changes
Jun 12, 2024
Co-authored-by: reiferschris <34450887+reiferschris@users.noreply.github.com>
|
You are right, that headers for that call is not optimal, although it is denied (there is no validation) for that endpoint. |
|
Thanks @reiferschris for your reporting and testing it |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #23,
Description
refer to the issue's desc.
Reason
The checker for hasVersion forces to call the performGet which ends up having overwrite the arguments of the Client object before the main call!
Solution
Cloning the object to get the version!