Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The warning triangle in case of a technical problem when sharing content seems lonely #1103

Closed
JulianKniephoff opened this issue Sep 5, 2023 · 9 comments · Fixed by #1113

Comments

@JulianKniephoff
Copy link
Member

@oas777 wrote in #1069 (comment):

The warning triangle in case of a technical problem when sharing content seems lonely: Could we integrate it into the (upper right corner) of the warning text?

to which @LukasKalbertodt replied in #1069 (comment):

Imagine the warning triangle being a placeholder for the video what would have appeared there. That was the idea anyway.
What do others think about this? Moving this would be easy.

Poor warning triangle. 😦

@narickmann
Copy link
Contributor

The triangle maybe looks a bit lonely, right, but I still think it makes sense as an eye-catcher, that something happened and needs my attention. (The red colour itself already does this, but the triangle emphasizes it)

If we put the triangle in the notification or into the corner, we might have too much empty/unused space. Not sure, if I like this.

Bildschirmfoto

Could this be an alternative: making the notification itself more central (and perhaps larger)? In the middle of the video element?

I like the little triangle as it is. But I'm also open to other suggestions.

@oas777
Copy link

oas777 commented Sep 13, 2023

Interestingly, this doesn't look too bad:

grafik

@narickmann
Copy link
Contributor

Yeah, this could be a solution. Maybe with a bit less strong red?

Maybe like this? It's still catchy but less aggressive (This is now 300px and the color is danger1)

grafik

@oas777
Copy link

oas777 commented Sep 14, 2023

Yeah, obviously mine was just a suggestion to understand the dimensions. Yours is much better.

@lkiesow
Copy link
Contributor

lkiesow commented Sep 14, 2023

More important than the icon is the message. I don't feel like putting a huge icon in the middle of the screen really helps. Why not just center the whole error message and put the icon right next to it?

Something like:
267647002-4584999a-7a07-4e6f-9dbb-5174afeec4f5

@oas777
Copy link

oas777 commented Sep 14, 2023

That's even better (and closer to my original suggestion).

@LukasKalbertodt
Copy link
Member

LukasKalbertodt commented Sep 14, 2023

What do you all think about #1113?

@oas777
Copy link

oas777 commented Sep 14, 2023

@lkiesow will surely complain about "a box in a box"...

@narickmann
Copy link
Contributor

What do you all think about #1113?

For smaller screens this may look good and fits better. But for larger screens I think the box around the notification is too small.

I think the larger box in Lars' suggestion looks better.

LukasKalbertodt added a commit to LukasKalbertodt/opencast-studio that referenced this issue Sep 28, 2023
LukasKalbertodt added a commit to LukasKalbertodt/opencast-studio that referenced this issue Sep 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
5 participants