Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

root tarballs not working? #1151

Closed
majosch opened this issue Nov 21, 2023 · 2 comments · Fixed by #1152
Closed

root tarballs not working? #1151

majosch opened this issue Nov 21, 2023 · 2 comments · Fixed by #1152

Comments

@majosch
Copy link
Contributor

majosch commented Nov 21, 2023

The root-flavor tarball from the latest release oc-studio-2023-11-20-root.tar.gz is not working? Because my browser wants to load studio from https://main.bundle.js/

In the index.html file the links to the stylesheets seem to be wrong?

<link rel="stylesheet" href="./font.css"><link rel="icon" href="//favicon.ico"><script defer="defer" src="//main.bundle.js"></script>

When building studio without export PUBLIC_PATH=/ the studio app loads fine.
@LukasKalbertodt
Copy link
Member

Thanks for catching that! I swear I tested this. But oh well, somehow I screwed this up. I created #1152 to fix this. After this is merged, I will release a new release.

@LukasKalbertodt LukasKalbertodt mentioned this issue Nov 21, 2023
Merged
owi92 added a commit that referenced this issue Dec 5, 2023
@owi92
Fix public path once again (#1152)
a8aeb77 
Hopefully for good this time. Now the normalization (always ends with
"/" is performed at the earliest possible moment). I tested with the env
var not set, set to "/" and set to "/build".

Fixes #1151
@LukasKalbertodt
Copy link
Member

The tarball is fixed in https://github.com/elan-ev/opencast-studio/releases/tag/2023-12-06

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix public path once again LukasKalbertodt/opencast-studio
2 participants
@LukasKalbertodt @majosch