Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consistent Settings Style #1012

Merged
merged 1 commit into from
Mar 6, 2023
Merged

Consistent Settings Style #1012

merged 1 commit into from
Mar 6, 2023

Conversation

LukasKalbertodt
Copy link
Member

This is just a rebased version of #993

I rebased it on the huge refactoring I did recently. While doing that I also reviewed the changes, which I... hereby approve :P

This patch updates the settings style to make the different settings
options use the same style. In particular, this means that:

- All input fields have labels
- Labels use the same font and are no longer sometimes bold
- Input element border color and radius are now identical

The last change will also effect some other views but a homogeneous
style makes sense for the whole user interface anyway. It is just not so
obvious on other pages.

This patch also puts the settings blocks in a flex-box so that we don't
end up with extremely wide dropdowns with text only on the very left. In
most cases you don't even need to scroll any longer.
@LukasKalbertodt LukasKalbertodt merged commit dfe4d4c into master Mar 6, 2023
@LukasKalbertodt LukasKalbertodt deleted the settings-style branch March 6, 2023 15:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants