Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Automate release #1026

Merged
merged 7 commits into from
Apr 20, 2023
Merged

Conversation

narickmann
Copy link
Contributor

@narickmann narickmann commented Apr 6, 2023

This fixes #945

An automatic release should now work like the automatic release from the editor.
I still have to adjust the documentation.

ToDo:

  • adjust Documentation

This fixes elan-ev#945
ToDo: adjust Documentation
@narickmann narickmann self-assigned this Apr 6, 2023
@narickmann narickmann marked this pull request as ready for review April 11, 2023 11:18
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, this will make releasing easier and likely more deterministic as the build is created on a fresh machine each time. Found a few small problems tho.

doc/make-release.md Outdated Show resolved Hide resolved
.github/release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/workflows/create-release.yml Outdated Show resolved Hide resolved
.github/create-release.sh Outdated Show resolved Hide resolved
doc/make-release.md Outdated Show resolved Hide resolved
doc/make-release.md Outdated Show resolved Hide resolved
doc/make-release.md Outdated Show resolved Hide resolved
doc/make-release.md Outdated Show resolved Hide resolved
@narickmann narickmann added type:documentation Improvements or additions to documentation type:infrastructure Build process, deployment, workflows labels Apr 19, 2023
I updated our issue/PR labels for Studio and adjusted the release categories.
This is already part of the `create-release.sh` script
... and pass "y" (yes) to the script
Copy link
Member

@LukasKalbertodt LukasKalbertodt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like the new labels!

.github/release.yml Outdated Show resolved Hide resolved
I corrected the links and switched from permalinks to non-permalinks. The links now lead to the corresponding file.
Also added back some points to the documentation that I previously removed. Hopefully making the documentation more clear.
... so that PRs without a label also appear in the release notes/changelog.
@LukasKalbertodt LukasKalbertodt merged commit 36a4345 into elan-ev:master Apr 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type:documentation Improvements or additions to documentation type:infrastructure Build process, deployment, workflows
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate release
2 participants